[Core] Rename transaction ID to payout ID in BulkPayout#3403
Closed
flopez7 wants to merge 6 commits intofeat/escrow-cancellationfrom
Closed
[Core] Rename transaction ID to payout ID in BulkPayout#3403flopez7 wants to merge 6 commits intofeat/escrow-cancellationfrom
flopez7 wants to merge 6 commits intofeat/escrow-cancellationfrom
Conversation
…ted tests - Updated the EscrowClient class to replace `txId` with `payoutId` in method signatures and internal logic. - Modified the GraphQL schema to reflect the change from `bulkPayoutTxId` to `payoutId`. - Adjusted the subgraph mapping functions to handle the new payout ID format. - Updated test cases to use the new payout ID instead of transaction ID. - Ensured consistency across all related files, including constants and event handling.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
…crowCompletionService in reputation oracle
portuu3
requested changes
Jun 25, 2025
| exchangeOracleFee | ||
| ); | ||
| eventRecipients[i] = _recipients[i]; | ||
| netAmounts[i] = |
Collaborator
There was a problem hiding this comment.
This can be before the transfer and then user netAmounts[i] as the amount for the transfer instead of calculating twice
| :param final_results_hash: Final results file hash | ||
| :param txId: Serial number of the bulks | ||
| :param payout_id: Payout ID for the transaction | ||
| :param force_complete: (Optional) Indicates if remaining balance should be transferred to the escrow |
Collaborator
There was a problem hiding this comment.
Suggested change
| :param force_complete: (Optional) Indicates if remaining balance should be transferred to the escrow | |
| :param force_complete: (Optional) Indicates if remaining balance should be transferred to the escrow creator |
| escrowCompletionEntity.finalResultsUrl as string, | ||
| escrowCompletionEntity.finalResultsHash as string, | ||
| DEFAULT_BULK_PAYOUT_TX_ID, | ||
| uuidv4(), |
Collaborator
There was a problem hiding this comment.
This should be obtained from intermediate results. Intermediate results still does not contain this info, but maybe we should add a TODO here
… messages in EscrowClient
Collaborator
|
Changes applied in #3482 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3400
Context behind the change
txIdwithpayoutIdin method signatures and internal logic.bulkPayoutTxIdtopayoutId.How has this been tested?
Ran unit tests
Deploy fortune locally
Release plan
Deploy new SDK version and smart contracts
Potential risks; What to monitor; Rollback plan
Check bulkpayout method is working properly